Feat: add builder methods to exp.Update and add with_ arg to exp.update #4217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgesittas
reviewed
Oct 7, 2024
There was a problem hiding this comment.
LGTM, just a few comments. Thanks a lot for the PR, @brdbry!
georgesittas
changed the title
…e suggestion that CTE query in with_ must be a Select (can include set operators)
georgesittas
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve ergonomics of UPDATEs:
exp.updatechanges:with_arg so updates with CTEs can be created in one-shot without subsequent need to.set(...)the With clausepropertiesarg optional, soset_builder method can be used with an AST (exp.update("tbl").set_(set_expr)) instead of forcing specification as adict